Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow force destroy and random string in bucket name [CDS-1505] #178

Merged
merged 3 commits into from
Oct 13, 2024

Conversation

guyrenny
Copy link
Contributor

@guyrenny guyrenny commented Sep 15, 2024

Description

Remove validation for the bucket names to allow users to use random string in the bucket name.
Add variables to allow force destroy to the bucket in case it is necessary

Fixes #104

How Has This Been Tested?

Checklist:

  • I have updated the relevant example in the examples directory for the module.
  • I have updated the relevant test file for the module.
  • This change does not affect module (e.g. it's readme file change)

@guyrenny guyrenny requested a review from a team as a code owner September 15, 2024 11:54
@guyrenny guyrenny changed the title Allow force destroy and random string in bucket name [CDS-1505] fix: Allow force destroy and random string in bucket name [CDS-1505] Oct 13, 2024
@guyrenny guyrenny merged commit 5e7e875 into master Oct 13, 2024
6 checks passed
@guyrenny guyrenny deleted the s3-archive-update branch October 13, 2024 12:29
Copy link

🎉 This PR is included in version 2.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants